ObserveGeneration and lastStableGeneration for FlinkBlueGreenDeployment - #30
Merged
Merged
Conversation
james-kan-shopify
force-pushed
the
observed-generation-blue-green
branch
from
July 14, 2026 18:10
c8865cd to
1d1c9f6
Compare
drossos
requested changes
Jul 15, 2026
drossos
left a comment
There was a problem hiding this comment.
Ok wrapped my head around things and seems to make sense. Have some structure changes and a q.
We also need to tophat to ensure would work as expected in deployed env
james-kan-shopify
force-pushed
the
observed-generation-blue-green
branch
2 times, most recently
from
July 16, 2026 21:13
f98cafc to
a2caf1b
Compare
james-kan-shopify
force-pushed
the
observed-generation-blue-green
branch
from
July 16, 2026 21:58
a2caf1b to
a418cc9
Compare
james-kan-shopify
marked this pull request as ready for review
July 16, 2026 23:01
drossos
approved these changes
Jul 17, 2026
drossos
left a comment
There was a problem hiding this comment.
LGTM after review + discussions. Will merge in after summit and roll-out 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request makes FlinkBlueGreenDeployment status generation-aware so external deploy tooling can
distinguish stale parent status from status that belongs to the currently applied spec generation.
Before this change, a BlueGreen parent could still report ACTIVE_BLUE / ACTIVE_GREEN and RUNNING from the
previous generation after Kubernetes had already accepted a new spec/image. This could allow kapp to mark a
deploy successful before the new BlueGreen generation had actually completed, especially around savepoint
handoff where the parent can temporarily return to ACTIVE_* / RUNNING before the new color is live.
The change adds two parent status fields with separate semantics:
observedGeneration provides the standard Kubernetes freshness signal used by kapp’s supportsObservedGeneration
behavior. lastStableGeneration provides the BlueGreen-specific completion signal needed because ACTIVE_* /
RUNNING alone is not always proof that the current parent generation is complete.
Brief change log
or SUSPENDED).
backfill, initial suspended deploys, and final active stability.
Verifying this change
This change added tests and can be verified as follows:
Verified locally with:
Result:
Also verified formatting with Spotless check for the touched module.
###Does this pull request potentially affect one of the following parts:
Documentation